RASHID778 commited on
Commit
7c365ce
·
verified ·
1 Parent(s): 3f7f872

guard against exploded loss (loss_cap/pred_cap) + adamw eps 1e-6

Browse files
Files changed (1) hide show
  1. scripts/train_continue.py +13 -4
scripts/train_continue.py CHANGED
@@ -69,6 +69,8 @@ def build_parser():
69
  ap.add_argument("--alpha", type=int, default=16)
70
  ap.add_argument("--seed", type=int, default=0)
71
  ap.add_argument("--max_grad_norm", type=float, default=1.0)
 
 
72
  ap.add_argument("--keep_checkpoints", action="store_true")
73
  return ap
74
 
@@ -261,7 +263,7 @@ def main() -> None:
261
  )
262
  saved_cfg = build_adapter_config(lora_targets, args.rank, args.alpha, args.base_model)
263
 
264
- optimizer = torch.optim.AdamW(trainable, lr=args.lr, weight_decay=1e-2)
265
  total_updates = args.max_train_steps
266
 
267
  def warmup_cosine(step: int) -> float:
@@ -359,11 +361,18 @@ def main() -> None:
359
  ).sample
360
  pred = pred.float()
361
  loss = torch.nn.functional.mse_loss(pred, noise.float()) / args.grad_accum
362
- if not torch.isfinite(loss):
 
 
 
 
 
 
 
363
  skipped += 1
364
  print(
365
- f"[warn] non-finite loss at step {global_step} micro {_micro} "
366
- f"row {pos - 1} - skipped",
367
  flush=True,
368
  )
369
  continue
 
69
  ap.add_argument("--alpha", type=int, default=16)
70
  ap.add_argument("--seed", type=int, default=0)
71
  ap.add_argument("--max_grad_norm", type=float, default=1.0)
72
+ ap.add_argument("--loss_cap", type=float, default=100.0)
73
+ ap.add_argument("--pred_cap", type=float, default=1000.0)
74
  ap.add_argument("--keep_checkpoints", action="store_true")
75
  return ap
76
 
 
263
  )
264
  saved_cfg = build_adapter_config(lora_targets, args.rank, args.alpha, args.base_model)
265
 
266
+ optimizer = torch.optim.AdamW(trainable, lr=args.lr, weight_decay=1e-2, eps=1e-6)
267
  total_updates = args.max_train_steps
268
 
269
  def warmup_cosine(step: int) -> float:
 
361
  ).sample
362
  pred = pred.float()
363
  loss = torch.nn.functional.mse_loss(pred, noise.float()) / args.grad_accum
364
+ loss_val = float(loss)
365
+ pred_max = float(pred.abs().max())
366
+ if (
367
+ not torch.isfinite(loss)
368
+ or not torch.isfinite(pred).all().item()
369
+ or loss_val > args.loss_cap
370
+ or pred_max > args.pred_cap
371
+ ):
372
  skipped += 1
373
  print(
374
+ f"[warn] unstable loss at step {global_step} micro {_micro} "
375
+ f"row {pos - 1} loss={loss_val:.3f} pred_max={pred_max:.3f} - skipped",
376
  flush=True,
377
  )
378
  continue